chore: extract/consolidate contributor pr workflow #32494
Conversation
…cleci config pack to compose them into the main workflows.yml file
…ck off pull-request workflow after approval
cacieprins
changed the title
cypress
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
ci/extract-contributor-workflow
|
| Run status |
|
| Run duration | 20m 33s |
| Commit |
|
| Committer | Cacie Prins |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
1
|
Flaky
|
12
|
Pending
|
1102
|
Skipped
|
4
|
Passing
|
26707
|
| View all changes introduced in this branch ↗︎ | |
Warning
Partial Report: The results for the Application Quality reports may be incomplete.
UI Coverage
45.27%
|
|
|---|---|
|
Untested elements
|
186
|
|
Tested elements
|
158
|
Accessibility
97.97%
|
|
|---|---|
|
Failed rules
|
4 critical
8 serious
2 moderate
2 minor
|
|
Failed elements
|
101
|
Tests for review
cypress/e2e/studio/studio.cy.ts • 1 failed test • app-e2e
| Test | Artifacts | |
|---|---|---|
| Cypress Studio > updates an existing test with assertions |
Test Replay
Screenshots
|
|
issues/28527.cy.ts • 1 flaky test • 5x-driver-electron
| Test | Artifacts | |
|---|---|---|
| issue 28527 > fails and then retries and verifies about:blank is not displayed |
Test Replay
Screenshots
|
|
commands/waiting.cy.js • 1 flaky test • 5x-driver-chrome
| Test | Artifacts | |
|---|---|---|
| ... > errors > throws when route is never resolved |
Test Replay
|
|
commands/actions/selectFile.cy.ts • 1 flaky test • 5x-driver-chrome
| Test | Artifacts | |
|---|---|---|
| ... > throws with aliased intercepts |
Test Replay
|
|
issues/28527.cy.ts • 1 flaky test • 5x-driver-chrome
| Test | Artifacts | |
|---|---|---|
| issue 28527 > fails and then retries and verifies about:blank is not displayed |
Test Replay
Screenshots
|
|
commands/net_stubbing.cy.ts • 1 flaky test • 5x-driver-firefox
| Test | Artifacts | |
|---|---|---|
| ... > stops waiting when an xhr request is canceled |
The first 5 flaky specs are shown, see all 12 specs in Cypress Cloud. | |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
@cacieprins I created #32574 to test this workflow out and job is running on https://app.circleci.com/pipelines/github/cypress-io/cypress/75143 |
Correct - this is the same pattern as the old |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
@cacieprins I think the jobs lacking the approval button are automatically locked
it looks to still be automatically locked after clicking approve and the workflow automatically fails
cacieprins
force-pushed
the
ci/extract-contributor-workflow
branch
from
663fdbc to
655fce9
Compare
|
@cacieprins I'm running a contributor PR running against the branch https://app.circleci.com/pipelines/github/cypress-io/cypress/75579 |
Additional details
Previously, we had an entirely separate workflow defined for contributor pull requests. This was implemented in order to require maintainer approval for running expensive CI jobs on contributor pull requests.
This consolidates the contributor PR into the primary
pull-requestworkflow, while keeping the same behavior.The
node_modules_install,build,check-ts,lint, andlint-typesjobs will still run for external contributors. Any subsequent jobs require that theapprove-contributor-prjob be approved by a maintainer. Because theapprove-contributor-prjob is conditional based on the branch pattern, declaring it as required for subsequent jobs will only be enforced if that job runs - internal contributor/maintainer PRs will not run that job, so it will be skipped as required.Steps to test
Fork this branch to another account, and open a pull request. Verify that it prevents expensive jobs from running prior to approval.
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?Note
Consolidates contributor PR handling into the main pull-request workflow with an approval gate and dynamic PR detection, and removes the separate contributor workflow.
workflows/pull-request.yml.internal-pr-buildandexternal-pr-buildwith branch filters; addsapprove-contributor-prapproval for external PRs before running gated jobs.percy-finalize,verify-accessibility-results) to a dedicated section.linux-x64-contributorworkflow and its jobs.linux-x64workflow intact; dependency lists adjusted accordingly.buildjob paramis_contributor_prwith dynamic detection based on<< pipeline.git.branch >>and passes it tocircle-env.js.Written by Cursor Bugbot for commit 5eccac1. This will update automatically on new commits. Configure here.